testkit: add --days flag to the credential minter - #8
Merged
Conversation
The non-expired test credentials were hardcoded to a 30-day window. The copies committed into the ar2 verifier tests crossed that cliff on Aug 20: test_valid_grant and three siblings began failing on every branch, and worse, the tampered/revoked fixtures kept "passing" vacuously -- rejected for expiry rather than for the property under test. Companion ar2 PR re-mints those fixtures with --days 365 and adds a conftest guard that fails loudly with the re-mint command when fixtures approach expiry. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testkit: add --days flag to the credential minter
The non-expired test credentials were hardcoded to a 30-day window. The
copies committed into the ar2 verifier tests crossed that cliff on Aug 20:
test_valid_grant and three siblings began failing on every branch, and
worse, the tampered/revoked fixtures kept "passing" vacuously -- rejected
for expiry rather than for the property under test.
Companion ar2 PR re-mints those fixtures with --days 365 and adds a
conftest guard that fails loudly with the re-mint command when fixtures
approach expiry.