Fix issue when creating session with non-default window name #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change if I executed a code block like the following
#+begin_src tmux :session default:foo
echo hello world
#+end_src
and no session named "default" exists, then first a session with a
window named "foo" would be created by (ob-tmux--create-session) and
then (sometimes) an additional window with the name "foo" would be
created by (ob-tmux--create-window). This has lead in my case to some
follow up failures. Therefore this change where always a window with
the default name is created for new sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change if I executed a code block like the following
#+begin_src tmux :session default:foo
echo hello world
#+end_src
and no session named "default" exists, then first a session with a window named "foo" would be created by (ob-tmux--create-session) and then (sometimes) an additional window with the name "foo" would be created by (ob-tmux--create-window). This has lead in my case to some follow up failures. Therefore this change where always a window with the default name is created for new sessions.