Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagemath cython3 #2

Closed

Conversation

tornaria
Copy link

@tornaria tornaria commented Aug 30, 2023

Testing the changes

  • I tested the changes in this PR: briefly

@ahesford Here's a first attempt to sagemath in cython3. Seems quite promising.

Second commit is just cherry-pick from void-linux#45708, which is mostly ready to go.

Third commit adds a patch to cysignals to avoid a warning (there are more warnings IIRC, but this is the only one which "leaks" to other packages since it is in a .pxd file).

There is a minor issue which is that cython version is hardcoded to 3.0.0 in a few doctests so they will fail in our current 3.0.2 (see sagemath/sage#36110 (comment)) but that will surely be fixed soon in sagemath/sage#36110.

ahesford and others added 30 commits August 28, 2023 11:05
@tornaria
Copy link
Author

Please squash the cysignals commit into the earlier one. But do not squash the "sagemath: update to 10.1" and "sagemath: update to cython 3.0" commits, so it's easier to track (let's agree to keep the first one as an unchanged cherry-pick of void-linux#45708 so it's easier to track that PR here).

@tornaria
Copy link
Author

I had messed up the patches. Since the PRs sagemath/sage#36109 and sagemath/sage#36110 are based on sagemath 10.2.beta0 and we want to apply on 10.1, I added a couple of small "pre-patches" which make it so that those PRs apply cleanly.

Hopefully now everything is ok.

@ahesford ahesford force-pushed the python3-Cython-3.0.0 branch 5 times, most recently from b5700c5 to 53461a8 Compare September 1, 2023 15:13
@ahesford ahesford deleted the branch ahesford:python3-Cython-3.0.0 September 1, 2023 17:32
@ahesford ahesford closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants