-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert license back to Apache 2 #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much of the code is derived from cpython itself. We can’t change the license without consent of the python contributors who write the asyncio code this library uses.
For history, the repo template is where the Apache license came from not the code. The code was never licensed under an Apache license. |
Wow thanks for the quick reply and context! I'll see if I can work with our scanning tool company to have the python license added as an acceptable license. In the meantime, @Dreamsorcerer mentioned in the issue that there were plans to merge this into cpython? Do you know how around when that would happen? because if so that would also resolve the license issue I'm hitting |
The license is intended to be the same as cpython itself https://spdx.org/licenses/Python-2.0.1.html Unfortunately there currently is no matching classifier: https://pypi.org/classifiers/ closes #79 closes #81
Once aio-libs/aiohttp#8599 gets fixed in cpython we should be able to start the process. I was hoping that would have been reported to cpython, but it seems like something we will need to help out with before it can be solved. |
Hopefully #82 will help with that. Since aren't many projects that use the same license as cpython it seems like the various toolings that check licenses don't know about python licenses or history, and even pypi is lacking a classifier for this case (unless I missed it). |
Here's a PR reverting the license to Apache like it was before. I'm having the same problem as other people in issue #79 in my company where we can't use this library (and therefore can't use aiohttp or any other libraries that rely on it, which is a lot) due to code scanning and license requirements.
Most companies have an internal SLA for fixing issues, so if it is going to be merged into cpython or anything else it would probably be ok to change it back to whatever license they need a month or so before it is merged in. That way before their company SLA is expired they can remove it as a direct import in their requirements.txt and stay compliant.