Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'read_timeout' parameter #974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aakulchyk
Copy link

What do these changes do?

Support 'read_timeout' parameter of the connection object from pymysql:
https://pymysql.readthedocs.io/en/latest/modules/connections.html#module-pymysql.connections

Are there changes in behaviour for the user?

The connection will be closed if timeout is reached (same behaviour as in pymysql)

Related issue number

#488

Checklist

  • [ x] I think the code is well written
  • [ x] Unit tests for the changes exist
  • Documentation reflects the changes

@aakulchyk aakulchyk force-pushed the master branch 2 times, most recently from 185b943 to 4b6fb3c Compare January 5, 2024 17:00
@@ -1,13 +1,13 @@
from unittest import mock

import aiomysql

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note test

Module 'aiomysql' is imported with both 'import' and 'import from'.
flask-rabmq pushed a commit to flask-rabmq/aiomysql that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant