[WIP] Bulk load cdk: add checkpointing test #46749
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
| * | ||
| */ | ||
| @Test | ||
| open fun testMidSyncCheckpointingStreamState() = runTest { |
There was a problem hiding this comment.
We probably don't want to use runTest for tests that wrap the destination process? I'm assuming the delay-suppressing behavior propagates to the application context? If so there are probably a couple of processes that either loop and sleep (like TimedForcedFlush) or busy wait (like awaiting flushes at the end) that are now blocking.
Probably the latter? Because it's taking the lock and checking the checkpoint maps over and over without giving anyone else a chance to flush?
Just a guess, try it with runBlocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?