-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source-Stripe: Add incremental stream support to accounts stream #46864
base: master
Are you sure you want to change the base?
✨ Source-Stripe: Add incremental stream support to accounts stream #46864
Conversation
@williamkaper is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
7ec7dc4
to
c017906
Compare
c017906
to
5bc1351
Compare
@@ -127,7 +127,7 @@ The Stripe source connector supports the following streams: | |||
- [Transactions](https://stripe.com/docs/api/transfers/list) \(Incremental\) | |||
- [Transfers](https://stripe.com/docs/api/transfers/list) \(Incremental\) | |||
- [Transfer Reversals](https://stripe.com/docs/api/transfer_reversals/list) | |||
- [Usage Records](https://stripe.com/docs/api/usage_records/subscription_item_summary_list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing the tests to fail - not sure how this got here...
5bc1351
to
44cecf8
Compare
/format-fix
|
What
This PR adds incremental sync support to the
accounts
stream (I did not create an issue because I figured I'd just submit the change via PR)How
I followed the pattern for other
UpdatedCursorIncrementalStripeStreams
and changed it fromStripeStream
toUpdatedCursorIncrementalStripeStream
keying off of the events for a new updated cursor column that I added to the ERD.Review guide
**** NOTE:** I did not update the unit_tests/integration for test_accounts.py. I was going to use one of the other tests in the holder to try to rewrite it, but it was beyond me. The tests are passing, but that test suite isn't testing the incremental part of the stream. I'm hoping a member of the Airbyte Stripe source connector team can pick that up.
User Impact
For merchants with large amounts of connected accounts, the stream update won't take hours to keep repulling needlessly.
Can this PR be safely reverted and rolled back?