Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban two Assertions classes from AssertJ #376

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Ban two Assertions classes from AssertJ #376

merged 1 commit into from
Sep 13, 2023

Conversation

ksobolew
Copy link
Contributor

Quoting the <reason>:

These classes were introduced to overcome type inference issues in
Java 8, but the regular org.assertj.core.api.Assertions works just
fine and has a richer API.

@ksobolew
Ban two Assertions classes from AssertJ
a2965e7 
Quoting the `<reason>`:

> These classes were introduced to overcome type inference issues in
> Java 8, but the regular `org.assertj.core.api.Assertions` works just
> fine and has a richer API.
@ksobolew ksobolew mentioned this pull request Sep 13, 2023
Merged
@electrum electrum merged commit 9e7750b into airlift:master Sep 13, 2023
2 checks passed
@ksobolew ksobolew deleted the kudi/ban-assertion-classes branch September 14, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@kokosing kokosing kokosing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksobolew @findepi @kokosing @electrum