Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developers section #380

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Improve developers section #380

merged 1 commit into from
Sep 22, 2023

Conversation

mosabua
Copy link
Contributor

@mosabua mosabua commented Sep 20, 2023

With the current setup any inheriting project has to override developers .. otherwise they get
the following in the effective pom:

<developers>
    <!-- see git log -->
    <developer>
        <name>Airlift</name>
    </developer>
</developers>

Which is wrong. This is currently the case in Trino for example.

The new setup pulls the scm url into place and results in a correct URL to the github or whatever repo and has a generic sentence instead of referencing airlift. Here is the effective pom for this project itself:

    <developers>
      <developer>
        <name>Numerous contributors, see scm log</name>
        <url>https://github.com/airlift/airbase</url>
      </developer>
    </developers>

It uses the property so for example in Trino we would get this:

    <developers>
      <developer>
        <name>Numerous contributors, see scm log</name>
        <url>https://github.com/trinodb/trino</url>
      </developer>
    </developers>

and in the Trino Gateway:

    <developers>
      <developer>
        <name>Numerous contributors, see scm log</name>
        <url>https://github.com/trinodb/trino-gateway</url>
      </developer>
    </developers>

Note that the property project.scm.url is filled in most cases since it is needed for Central deployment and release plugin usage.

Discovered during work on trinodb/trino-gateway#29 and requested by @dain

FYI @electrum @martint

@electrum electrum merged commit 42611a8 into airlift:master Sep 22, 2023
2 checks passed
@mosabua mosabua deleted the devs branch September 22, 2023 03:28
@mosabua
Copy link
Contributor Author

mosabua commented Sep 22, 2023

Thanks for the merge @electrum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants