Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current setup any inheriting project has to override developers .. otherwise they get
the following in the effective pom:
Which is wrong. This is currently the case in Trino for example.
The new setup pulls the scm url into place and results in a correct URL to the github or whatever repo and has a generic sentence instead of referencing airlift. Here is the effective pom for this project itself:
It uses the property so for example in Trino we would get this:
and in the Trino Gateway:
Note that the property
project.scm.url
is filled in most cases since it is needed for Central deployment and release plugin usage.Discovered during work on trinodb/trino-gateway#29 and requested by @dain
FYI @electrum @martint