Add enforcer rules #554
Merged
Add enforcer rules #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/add-enforcer-rules
branch
2 times, most recently
from
36cb1cb
to
c143a7f
Compare
martint
reviewed
Oct 23, 2024
wendigo
force-pushed
the
serafin/add-enforcer-rules
branch
from
c143a7f
to
aef6bcd
Compare
martint
approved these changes
Oct 23, 2024
electrum
approved these changes
Oct 23, 2024
| @@ -777,6 +777,7 @@ | |||
| <bannedImport>org.assertj.core.api.AssertionsForInterfaceTypes.*</bannedImport> | |||
| </bannedImports> | |||
| </RestrictImports> | |||
| <requireProfileIdsExist /> | |||
There was a problem hiding this comment.
Let's move this above all the RestrictImports
| @@ -778,6 +778,9 @@ | |||
| </bannedImports> | |||
| </RestrictImports> | |||
| <requireProfileIdsExist /> | |||
| <requirePropertyDiverges> | |||
There was a problem hiding this comment.
Same, since the RestrictImports list is so big, let's leave it last
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airbase contribution check list