Goやってる人にレビューもらったので共有

.gitignore

@@ -1,2 +1,4 @@
 .vscode/
-.idea/
+.idea/
+
+vendor/

backend/Dockerfile

@@ -13,4 +13,4 @@ RUN go build -o /keigo_server
 FROM alpine:latest as production-stage
 COPY --from=build-stage /keigo_server .
 EXPOSE 3000
-ENTRYPOINT ["./keigo_server"]
+ENTRYPOINT ["./keigo_server"]

backend/controllers/v1/keigo.go

@@ -1,38 +1,57 @@
 package v1
 
 import (
-	"github.com/gin-gonic/gin"
-	"keigo/models"
 	"net/http"
-)
 
-type KeigoController struct{}
+	"github.com/aizu-go-kapro/keiGo/backend/models"
+	"github.com/gin-gonic/gin"
+)
 
 const (
-	Teinei string = "teinei"
-	Sonkei string = "sonkei"
-	Kenjyo string = "kenjyo"
+	teineiKind = "teinei"
+	sonkeiKind = "sonkei"
+	kenjyoKind = "kenjyo"
 )
+// Keigo is controller of keigo
+type Keigo struct {
+	teinei models.Teinei
+	sonkei models.Sonkei
+	kenjyo models.Kenjyo
+}
+
+// NewKeigo create keigo controller
+func NewKeigo() *Keigo {
+	return &Keigo{}
+}
+
+// ConvertKeigo is controller
+func (kc *Keigo) ConvertKeigo(c *gin.Context) {
+	var (
+		request  models.KeigoRequest
+		response models.KeigoResponse
+	)
 
-func (kc *KeigoController) ConvertKeigo(c *gin.Context) {
 	kind := c.Query("kind")
-	print(kind)
-	request := models.KeigoRequest{}
-	response := models.KeigoResponse{}
+	if kind == "" {
+		return c.JSON(
+			http.StatusBadRequest, 
+			map[string]string{"status": "error", "message": "kind is empty"}
+			// '{"status": "error", "message": "kind is empty"}'
+		)
+	}
+
 	if err := c.BindJSON(&request); err != nil {
-		c.Status(http.StatusBadRequest)
-	} else {
-		switch kind {
-		case Teinei:
-			teinei := models.Teinei{}
-			response.ConvertedBody = teinei.Convert(request.Body)
-		case Sonkei:
-			sonkei := models.Sonkei{}
-			response.ConvertedBody = sonkei.Convert(request.Body)
-		case Kenjyo:
-			kenjyo := models.Kenjyo{}
-			response.ConvertedBody = kenjyo.Convert(request.Body)
-		}
-		c.JSON(http.StatusOK, response)
+		return c.Status(http.StatusBadRequest)
 	}
+
+	switch kind {
+	case teineiKind:
+		response.ConvertedBody = kc.teinei.Convert(request.Body)
+	case sonkeiKind:
+		response.ConvertedBody = kc.sonkei.Convert(request.Body)
+	case kenjyoKind:
+		response.ConvertedBody = kc.kenjyo.Convert(request.Body)
+	}
+
+	return c.JSON(http.StatusOK, response)
 }

backend/go.mod

@@ -1,6 +1,6 @@
-module keigo
+module github.com/aizu-go-kapro/keiGo/backend
 
-go 1.13
+go 1.14
 
 require (
 	github.com/gin-gonic/gin v1.6.3

backend/main.go

@@ -1,16 +1,28 @@
 package main
 
 import (
+	"io/ioutil"
+
+	controllers "github.com/aizu-go-kapro/keiGo/backend/controllers/v1"
+	"github.com/aizu-go-kapro/keiGo/backend/utils"
 	"github.com/gin-gonic/gin"
-	controllers "keigo/controllers/v1"
 )
 
+// go fmt ...
+
 func main() {
+	kenjo, err := ioutil.ReadFile("./utils/" + "kenjo.json")
+	if err != nil {
+		panic(err)
+	}
+	util := utils.Utils{
+		Kenjo: kenjo,
+	}
 	router := gin.Default()
+	kC := controllers.NewKeigo()
 	api := router.Group("/api/v1")
 	{
-		kc := new(controllers.KeigoController)
-		api.GET("/keigo", kc.ConvertKeigo)
+		api.GET("/keigo", kC.ConvertKeigo)
 	}
 	router.Run(":3000")
 }

backend/models/kenjyo.go

@@ -2,30 +2,36 @@ package models
 
 import (
 	"fmt"
-	"keigo/utils"
 	"strings"
 
+	"github.com/aizu-go-kapro/keiGo/backend/utils"
+
 	"github.com/ikawaha/kagome/tokenizer"
 )
 
-type Kenjyo struct{}
+type Kenjyo struct{
+	Utils: utils,
+}
+
 
-func (k *Kenjyo) Convert(body string) string {
+func (k *Kenjyo) Convert(body string) (string, error) {
 	kagome := Kagome{}
 	tokens := kagome.MorphologicalAnalysis(body)
 
 	utils := utils.Utils{}
-	conversionRules := utils.JsonDecoder("kenjyo.json")
+	conversionRules, err := utils.JsonDecoder("kenjyo.json")
+	if err != nil {
+		return "", err
+	}
 
 	var convertedBody = ""
 
 	endOfSentenceTokenIndex := len(tokens) - 1
 	for {
 		if tokens[endOfSentenceTokenIndex].Features()[0] == "記号" {
 			endOfSentenceTokenIndex--
-		} else {
-			break
-		}
+		} 
+		break
 	}
 
 	for _, token := range tokens {

backend/models/sonkei.go

@@ -2,9 +2,10 @@ package models
 
 import (
 	"fmt"
-	"keigo/utils"
 	"strings"
 
+	"github.com/aizu-go-kapro/keiGo/backend/utils"
+
 	"github.com/ikawaha/kagome/tokenizer"
 )
 
@@ -14,9 +15,7 @@ func (s *Sonkei) Convert(body string) string {
 	kagome := Kagome{}
 	tokens := kagome.MorphologicalAnalysis(body)
 
-	utils := utils.Utils{}
 	conversionRules := utils.JsonDecoder("sonkei.json")
-
 	var convertedBody = ""
 
 	endOfSentenceTokenIndex := len(tokens) - 1

backend/utils/utils.go

@@ -1,33 +1,35 @@
-package utils
+package converter
 
 import (
 	"encoding/json"
 	"io/ioutil"
-	"log"
 )
 
 type (
-	Utils struct{}
+	Utils struct {
+		Path string // json ファイルのパス
+	}
 
 	ConversionRule struct {
 		Original  string `json:"original"`
 		Converted string `json:"converted"`
 	}
 )
 
-func (u *Utils) JsonDecoder(filename string) []ConversionRule {
+func (u *Utils) JsonDecoder(filename string) ([]ConversionRule, error) {
 	// File openは実行時パスから見た相対パスになる
 	bytes, err := ioutil.ReadFile("./utils/" + filename)
 	if err != nil {
-		log.Fatal(err)
+		return nil, err
 	}
+
 	// JSONデコード
 	var conversionRules []ConversionRule
 	if err := json.Unmarshal(bytes, &conversionRules); err != nil {
-		log.Fatal(err)
+		return nil, err
 	}
 
-	return conversionRules
+	return conversionRules, nil
 }
 
 func (u *Utils) FindConvertedFromConversionRule(conversionRules []ConversionRule, original string) string {