fix(lint): shell lint

Signed-off-by: Artur Troian <troian.ap@gmail.com>

.envrc

@@ -48,6 +48,21 @@ if ! has readlink; then
 	exit 1
 fi
 
+if ! has pv; then
+	echo "pv is not installed"
+	exit 1
+fi
+
+if ! has lz4; then
+	echo "lz4 is not installed"
+	exit 1
+fi
+
+if ! has git-cliff; then
+	echo "git-cliff  is not installed"
+	exit 1
+fi
+
 if [ -z "$GOPATH" ]; then
 	GOPATH=$(go env GOPATH)
 	export GOPATH

.github/workflows/tests.yaml

@@ -189,7 +189,7 @@ jobs:
         run: make release
 
   network-upgrade-names:
-    runs-on: upgrade-tester
+    runs-on: self-hosted1
     steps:
       - name: Cleanup build folder
         run: |
@@ -222,7 +222,7 @@ jobs:
               ./script/semver.sh validate "$upgrade"
           done <<< $(find "$dir" ! -path "$dir" -maxdepth 1 -type d -exec basename {} \;)
   network-upgrade:
-    runs-on: upgrade-tester
+    runs-on: self-hosted1
     steps:
       - name: Cleanup build folder
         run: |

make/test-upgrade.mk

@@ -22,6 +22,8 @@ UPGRADE_BINARY_VERSION  ?= local
 REMOTE_TEST_WORKDIR     ?= ~/go/src/github.com/akash-network/node
 REMOTE_TEST_HOST        ?=
 
+COSMOVISOR  := /Users/amr/go/src/github.com/cosmos/cosmos-sdk/tools/cosmovisor/cosmovisor
+
 $(AKASH_INIT):
 	$(ROOT_DIR)/script/upgrades.sh --workdir=$(AP_RUN_DIR) --gbv=$(GENESIS_BINARY_VERSION) --ufrom=$(UPGRADE_FROM) --uto=$(UPGRADE_TO) --config="$(PWD)/config.json" init
 	touch $@

script/upgrades.sh

@@ -258,13 +258,6 @@ function init() {
 			cp "$validators_dir/.akash0/cosmovisor/upgrades/$UPGRADE_TO/bin/akash" "$upgrade_bin/akash"
 		fi
 
-		pushd "$(pwd)"
-		cd "$cosmovisor_dir"
-
-		ln -snf "current" "genesis"
-
-		popd
-
 		AKASH=$genesis_bin/akash
 
 		$AKASH init --home "$valdir" "$(jq -rc '.moniker' <<<"$val")" >/dev/null 2>&1
@@ -286,6 +279,7 @@ function init() {
 
 					tar_cmd=$(content_type "$(content_name "$GENESIS_ORIG")")
 
+					# shellcheck disable=SC2086
 					wget -nv -O - "$GENESIS_ORIG" | pv $pv_args | eval "$tar_cmd"
 				else
 					echo "unable to download genesis"
@@ -441,13 +435,6 @@ function bins() {
 			cp "$validators_dir/.akash0/cosmovisor/upgrades/$UPGRADE_TO/bin/akash" "$upgrade_bin/akash"
 		fi
 
-		pushd "$(pwd)"
-		cd "$cosmovisor_dir"
-
-		ln -snf "genesis" "current"
-
-		popd
-
 		((cnt++)) || true
 	done
 }

tests/upgrade/upgrade_test.go

@@ -546,13 +546,6 @@ func TestUpgrade(t *testing.T) {
 				fail = true
 			}
 		}
-
-		// select {
-		// case errs := <-vl.testErrsCh:
-		//
-		//
-		// case <-vl.ctx.Done():
-		// }
 	}
 
 	if fail {