Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement resource id and refactor sdl parsing #1855

Merged
merged 1 commit into from
Jul 24, 2023
Merged

feat: implement resource id and refactor sdl parsing #1855

merged 1 commit into from
Jul 24, 2023

Conversation

troian
Copy link
Member

@troian troian commented Jul 20, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

@troian troian requested a review from a team as a code owner July 20, 2023 00:10
@troian troian force-pushed the implement-resource-id branch 2 times, most recently from 348fecc to c61c4be Compare July 20, 2023 00:22
@troian troian force-pushed the implement-resource-id branch 2 times, most recently from 3a37370 to 5b46146 Compare July 20, 2023 13:40
@troian
feat: implement resource id and refactor sdl parsing
6588466 
Signed-off-by: Artur Troian <troian.ap@gmail.com>
@github-actions github-actions bot removed the Type: CI label Jul 20, 2023
@troian troian merged commit 73b4373 into main Jul 24, 2023
16 of 17 checks passed
@troian troian deleted the implement-resource-id branch July 24, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:CLI C:upgrades C:x/deployment C:x/market
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@troian