Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass along new polling_opts #249

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Pass along new polling_opts #249

merged 1 commit into from
Sep 19, 2024

Conversation

benonymus
Copy link
Contributor

@benonymus benonymus commented Sep 13, 2024

The newly added opts for Polling.build/5 are not passed from the Oban plugin when called like so:

{Plugins.Oban, oban_supervisors: [Oban], poll_rate: 10_000, opts: [detach_on_error: false]}

#236
3feeceb

@coveralls
Copy link

Coverage Status

coverage: 76.954% (-0.2%) from 77.131%
when pulling 56c19c4 on benonymus:master
into 6f97943 on akoutmos:master.

@akoutmos akoutmos merged commit 0eec6cb into akoutmos:master Sep 19, 2024
4 of 5 checks passed
@akoutmos
Copy link
Owner

Good catch! Thanks for the fix.

@smn
Copy link

smn commented Oct 8, 2024

@akoutmos any chance a new release could be made to include this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants