-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply flutter_lints and update Android example #64
Conversation
This one can be closed as I merged it in #66 |
This repo is actively maintained just a few hurdles to cross. Also, your PR is not merged yet @millerf how do you mean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review...
@millerf At Albert Heijn we wanted to use this package, but also found some issues and possible improvement that we wanted first. After I got in contact with @LuisThein we decided to move the whole package to the Albert Heijn Technology organisation and we just started making improvements. This PR is the first step in that, but we have to manage some corporate administration first. The second step (which was the requirement of AH) is that we are going to migrate to a federated plugin setup. The big benefit of that is that you only add dependencies that you actually use. In the current setup the iOS app will also depend on the native Google Maps libraries, while you don't want that. Once we are migrated to the federated setup we'll take a look at other issues and feature requests. So there is definitely no reason to publish a different fork to pub.dev as we'll also take over the pub.dev ownership from Luis. |
@renefloor Please let us know when the new plugin is published.. |
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
Signed-off-by: Rene Floor <rene.floor@ah.nl>
4b36292
to
73e4cc3
Compare
This PR adds an analysis_options file with
flutter_lints
and applies all the changes suggested by the analyzer.I deliberately haven't updated pubspec or changelog, because nothing really changed.
List which issues are fixed by this PR.
Pre-launch Checklist
///
).