hwmon: Differentiate between Aquaero 5 and 6, add pwm_mode support #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksamagicka
force-pushed
the
aquaero-pwm_mode
branch
from
66a9085
to
c557e33
Compare
leoratte
approved these changes
Aug 1, 2023
aleksamagicka
force-pushed
the
aquaero-pwm_mode
branch
from
c557e33
to
8486459
Compare
|
Thanks, added your tags to these commits. |
|
This is the next thing that I'm sending to LKML soon. |
|
TODO: update for #92. |
aleksamagicka
force-pushed
the
aquaero-pwm_mode
branch
2 times, most recently
from
df410e0
to
5548726
Compare
|
Now updated after #92. |
Aquaero devices expose their hardware version in the sensor report. Read it and show it through debugfs. Co-developed-by: Leonard Anderweit <leonard.anderweit@gmail.com> Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
With the raw hardware version value now read from the sensor report, determine whether it's an Aquaero 5 or 6. Co-developed-by: Leonard Anderweit <leonard.anderweit@gmail.com> Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Expose reading and writing hwmon_pwm_mode for Aquaero devices. Aquaero 5 can physically accept only one PWM fan (in the fourth slot), while Aquaero 6 can accept both DC and PWM fans in all four slots. Co-developed-by: Leonard Anderweit <leonard.anderweit@gmail.com> Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
aleksamagicka
force-pushed
the
aquaero-pwm_mode
branch
from
5548726
to
87aa947
Compare
|
Updated 6c86ba7 and made the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series adds support for reading and writing hwmon_pwm_mode for Aquaero devices. While the Aquaero 6 supports both DC and PWM fans for all four physical slots, Aquaero 5 supports PWM only for the fourth fan slot.
Patch 1 reads the Aquaero hardware version, which the devices send as part of the sensor report, and exposes it through debugfs.
Patch 2 uses that raw version value and differentiates between Aquaero 5 and 6, which is necessary to know to be able to expose the right amount of entries.
Patch 3 implements the hwmon_pwm_mode functionality.
@leoratte, do I have your
Co-developed-by:andSigned-off-by:for these patches, since we worked on them together in #70? (Assuming you're OK with them.)