Exclude semantics on outside days when not visible #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when `CalendarStyle.outsideDaysVisible` is set to false the table cells representing outside days can be focused by screen readers. Nothing is read when an outside day is focused, so screen reader users are likely to be confused and may not realize they need to skip over several empty cells. This commit excludes semantics on those empty cells when `CalendarStyle.outsideDaysVisible` is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! I have a minor change here to improve the screen reader experience.
Currently, when
CalendarStyle.outsideDaysVisibleis set to false the table cells representing outside days can be focused by screen readers. Nothing is read when an outside day is focused, so screen reader users are likely to be confused and may not realize they need to skip over several empty cells. It looks like this:This PR excludes semantics on those empty cells when
CalendarStyle.outsideDaysVisibleis false.