Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report different states to azure test plans #39

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

joerg1985
Copy link
Contributor

This PR implements the change described in #38 without the option to configure the mapping.

I have no NodeJs IDE or the option to test this changes locally, so please review.

@joerg1985 joerg1985 marked this pull request as draft August 8, 2023 20:41
@alexneo2003
Copy link
Owner

@joerg1985 I appreciate you work
I am added a little bit fixes in you code but I not added config mapping
also I published package as beta, check out

@alex_neo/playwright-azure-reporter@1.6.0-beta.0

@joerg1985
Copy link
Contributor Author

@alexneo2003

thank you, will test it in the next days and give feedback.

@joerg1985
Copy link
Contributor Author

joerg1985 commented Aug 10, 2023

skipped = 'Not Applicable', should be skipped = 'NotApplicable', looks like we need to hit a Enum name here.

All the enums are listed here, so we can map other values too:

  • timedOut to Timeout
  • interrupted to Aborted

@joerg1985
Copy link
Contributor Author

@alexneo2003 could you please create a new beta with the latest fixes?

@alexneo2003
Copy link
Owner

@alexneo2003 could you please create a new beta with the latest fixes?

@alex_neo/playwright-azure-reporter@1.6.0-beta.1

@joerg1985
Copy link
Contributor Author

I had a look at the last runs of the pipeline and the results look good, this could be merged.

The only thing to notice is that the 'Aborted' status does not update the state shown, but it will be listed in the details.
To check this i had to call the API with the 'Aborted' status, as this state is IMHO not reachable when running in the CI.

PS: i think the 'colors' dependency could be removed or did i miss the usage in the code?
https://github.com/alexneo2003/playwright-azure-reporter/blob/main/package.json#L43

@alexneo2003 alexneo2003 marked this pull request as ready for review August 16, 2023 12:41
@alexneo2003 alexneo2003 merged commit 0e7bad5 into alexneo2003:main Aug 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants