-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding fixes to allow working with local filesystem files when interacting with algokit goal commands #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorumbayev
reviewed
Aug 4, 2023
aorumbayev
reviewed
Aug 4, 2023
aorumbayev
reviewed
Aug 4, 2023
aorumbayev
reviewed
Aug 4, 2023
robdmoore
reviewed
Aug 11, 2023
Coverage Report
|
aorumbayev
reviewed
Aug 18, 2023
aorumbayev
reviewed
Aug 18, 2023
aorumbayev
reviewed
Aug 18, 2023
aorumbayev
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@negar-abbasi minor tweaks left please address otherwise LGTM.
Approving the pr, @robdmoore if you'll have time to take a peek on Monday for final sanity check would be great, will try to coordinate to have this as part of 1.4.1 release on monday
aorumbayev
changed the title
feat: Adding volume mount for goal commands
fix: adding fixes to allow working with local filesystem files when interacting with algokit goal commands
Aug 18, 2023
neilcampbell
approved these changes
Aug 19, 2023
Co-authored-by: Al <aorumbayev@pm.me>
Co-authored-by: Al <aorumbayev@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.