Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding fixes to allow working with local filesystem files when interacting with algokit goal commands #304

Merged
merged 42 commits into from
Aug 21, 2023

Conversation

negar-abbasi
Copy link
Contributor

No description provided.

@aorumbayev aorumbayev marked this pull request as draft July 31, 2023 09:36
tests/goal/test_goal.py Outdated Show resolved Hide resolved
tests/goal/test_goal.py Outdated Show resolved Hide resolved
tests/goal/test_goal.py Outdated Show resolved Hide resolved
tests/goal/test_goal.py Outdated Show resolved Hide resolved
src/algokit/core/goal.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit
   __init__.py15753%6–13, 17–24, 32–34
   __main__.py220%1–3
src/algokit/cli
   completions.py105298%80, 95
   deploy.py56591%34–36, 78, 96
   doctor.py48394%142–144
   generate.py57198%116
   goal.py39197%57
   init.py1901692%268–269, 319, 322–324, 335, 379, 405, 445, 454–456, 459–464, 477
   localnet.py91397%157, 178–179
src/algokit/core
   bootstrap.py1612485%103–104, 126, 149, 214, 217, 223–237, 246–251
   conf.py54885%10, 24, 28, 36, 38, 71–73
   deploy.py691184%61–64, 73–75, 79, 84, 91–93
   doctor.py65789%67–69, 92–94, 134
   generate.py41295%68, 86
   goal.py56395%27–28, 38
   log_handlers.py68790%50–51, 63, 112–116, 125
   proc.py45198%98
   sandbox.py1501590%100–107, 118, 227, 243, 258–260, 276
   typed_client_generation.py80594%55–57, 70, 75
   version_prompt.py73889%27–28, 40, 59–62, 80, 109
TOTAL162913192% 

Tests Skipped Failures Errors Time
247 0 💤 0 ❌ 0 🔥 14.784s ⏱️

src/algokit/cli/goal.py Outdated Show resolved Hide resolved
src/algokit/core/sandbox.py Outdated Show resolved Hide resolved
tests/goal/test_goal.py Outdated Show resolved Hide resolved
docs/features/goal.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@aorumbayev aorumbayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@negar-abbasi minor tweaks left please address otherwise LGTM.
Approving the pr, @robdmoore if you'll have time to take a peek on Monday for final sanity check would be great, will try to coordinate to have this as part of 1.4.1 release on monday

@aorumbayev aorumbayev changed the title feat: Adding volume mount for goal commands fix: adding fixes to allow working with local filesystem files when interacting with algokit goal commands Aug 18, 2023
negar-abbasi and others added 3 commits August 21, 2023 09:15
Co-authored-by: Al <aorumbayev@pm.me>
Co-authored-by: Al <aorumbayev@pm.me>
@aorumbayev aorumbayev merged commit caca2b5 into main Aug 21, 2023
3 checks passed
@aorumbayev aorumbayev deleted the volume-mount branch August 21, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants