Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: algokit dispenser #309

Merged
merged 35 commits into from
Oct 2, 2023
Merged

feat: algokit dispenser #309

merged 35 commits into from
Oct 2, 2023

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Aug 31, 2023

Proposed Changes

  • introducing algokit dispenser, an interface for interactions with DispenserAPI
  • all commands are accessible via account group however login and logout are aliased at the root for better access and convenience

TODO

  • - Snapshot tests -> (@neilcampbell @robdmoore) Please note this will be addressed in a separate pr from auth0-snapshot-tests branch and opened against this repo to simplify PR review given that snapshot tests will cover a lot of functionality
  • - Replacing endpoints with prod urls with ability to overwrite via env var
  • - Refined error handling and messages

@aorumbayev aorumbayev changed the title [DRAFT] algokit account implementation [DRAFT] algokit dispenser implementation Sep 1, 2023
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/core/dispenser.py Outdated Show resolved Hide resolved
src/algokit/core/dispenser.py Outdated Show resolved Hide resolved
src/algokit/core/dispenser.py Outdated Show resolved Hide resolved
src/algokit/core/dispenser.py Outdated Show resolved Hide resolved
tests/test_root.test_help.approved.txt Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit
   __init__.py15753%6–13, 17–24, 32–34
   __main__.py220%1–3
src/algokit/cli
   completions.py105298%80, 95
   deploy.py56591%34–36, 78, 96
   dispenser.py116199%74
   doctor.py48394%142–144
   generate.py57198%116
   goal.py39197%57
   init.py1901692%272–273, 323, 326–328, 339, 383, 409, 449, 458–460, 463–468, 481
   localnet.py93397%162, 183–184
src/algokit/core
   bootstrap.py1612485%103–104, 126, 149, 214, 217, 223–237, 246–251
   conf.py54885%10, 24, 28, 36, 38, 71–73
   deploy.py691184%61–64, 73–75, 79, 84, 91–93
   dispenser.py2022687%88, 120–121, 138–146, 188–189, 195–197, 215–216, 256–257, 315, 329–331, 342–343, 353, 366, 381
   doctor.py65789%67–69, 92–94, 134
   generate.py41295%68, 86
   goal.py56395%27–28, 38
   log_handlers.py68790%50–51, 63, 112–116, 125
   proc.py45198%98
   sandbox.py1811592%100–107, 118, 278, 294, 309–311, 327
   typed_client_generation.py80594%55–57, 70, 75
   utils.py18289%27–28
   version_prompt.py73889%27–28, 40, 59–62, 80, 109
TOTAL199016092% 

Tests Skipped Failures Errors Time
285 0 💤 0 ❌ 0 🔥 27.437s ⏱️

Copy link
Contributor

@neilcampbell neilcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to be converted to a non draft PR?

src/algokit/cli/dispenser.py Show resolved Hide resolved
src/algokit/cli/dispenser.py Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/core/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
* docs: adding initial docs on algokit dispense command

* chore: addressing pr comments
@aorumbayev aorumbayev changed the title [DRAFT] algokit dispenser implementation algokit dispenser implementation Sep 7, 2023
@aorumbayev aorumbayev marked this pull request as ready for review September 7, 2023 18:29
docs/cli/index.md Outdated Show resolved Hide resolved
docs/features/dispenser.md Outdated Show resolved Hide resolved
docs/features/dispenser.md Outdated Show resolved Hide resolved
docs/features/dispenser.md Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/cli/dispenser.py Outdated Show resolved Hide resolved
src/algokit/core/dispenser.py Show resolved Hide resolved
src/algokit/core/dispenser.py Outdated Show resolved Hide resolved
aorumbayev and others added 12 commits September 11, 2023 17:58
Co-authored-by: Neil Campbell <neil@codecise.com>
Co-authored-by: Neil Campbell <neil@codecise.com>
…nd (#311)

* test: initial snapshot tests

* test: adding snapshot tests

* refactor:  adding explicit tests for refreshing of the token

* chore: recreating approved tests part 1

* chore: recreating approved tests part 2

* chore: partially addressing pr comments

* chore: addressing remaining pr comments

* chore: updating audience

* chore: addressing pr comments
@aorumbayev aorumbayev changed the title algokit dispenser implementation feat: algokit dispenser implementation Sep 25, 2023
@aorumbayev aorumbayev changed the title feat: algokit dispenser implementation feat: algokit dispenser Sep 25, 2023
@aorumbayev aorumbayev merged commit 6b7a514 into main Oct 2, 2023
3 checks passed
@aorumbayev aorumbayev deleted the auth0 branch October 2, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants