Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting photon/thread/* to Windows with mingw #185

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

lihuiba
Copy link
Collaborator

@lihuiba lihuiba commented Sep 13, 2023

all cases in thread's UT are passed

 g++ -std=c++17 -I ../../include/ ../thread-pool.cpp ../workerpool.cpp test.cpp ../thread-key.cpp ../../common/identity-pool.cpp x.cpp ../../common/alog.cpp -D_POSIX_C_SOURCE -O2 -DTEST

note that:
1. -std=c++17 is required (but I don't konw why);
2. -D_POSIX_C_SOURCE is required for alog.cpp to use gmtime_r();
3. -DTEST is required for x.cpp to provide mocks of photon::init() and photon::fini();
x
in thread/test/
g++ -std=c++17 -I ../../include/ -DThreadUT test.cpp x.cpp ../thread-pool.cpp ../workerpool.cpp ../thread-key.cpp ../../common/identity-pool.cpp ../../common/alog.cpp -lgtest -lgflags -O2
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

@beef9999 beef9999 merged commit 56fb370 into alibaba:main Sep 20, 2023
4 of 5 checks passed
@lihuiba
Copy link
Collaborator Author

lihuiba commented Oct 13, 2023

image

@lihuiba lihuiba deleted the windows branch January 3, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants