Skip to content

Commit

Permalink
fix(useAntdTable): search submit init should use defaultPagination (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
hchlq authored Aug 27, 2023
1 parent 3fc5493 commit 185af79
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 2 deletions.
29 changes: 28 additions & 1 deletion packages/hooks/src/useAntdTable/__tests__/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ describe('useAntdTable', () => {
});
await waitFor(() => expect(queryArgs.current).toBe(1));
expect(queryArgs.current).toBe(1);
expect(queryArgs.pageSize).toBe(5);
// expect(queryArgs.pageSize).toBe(5);
expect(queryArgs.name).toBe('change name');
});

Expand Down Expand Up @@ -320,4 +320,31 @@ describe('useAntdTable', () => {
expect(queryArgs.pageSize).toBe(20);
});
});

it('search submit use default params', async () => {
queryArgs = undefined;
form.resetFields();
act(() => {
hook = setUp(asyncFn, {
form,
defaultParams: [
{
current: 2,
pageSize: 100,
},
],
});
});

const { search } = hook.result.current;

act(() => {
search.submit();
});

await waitFor(() => {
expect(queryArgs.current).toBe(2);
expect(queryArgs.pageSize).toBe(100);
});
});
});
16 changes: 15 additions & 1 deletion packages/hooks/src/useAntdTable/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ const useAntdTable = <TData extends Data, TParams extends Params>(
const result = usePagination<TData, TParams>(service, {
manual: true,
...rest,
onSuccess(...args) {
// eslint-disable-next-line @typescript-eslint/no-use-before-define
runSuccessRef.current = true;
rest.onSuccess?.(...args);
},
});

const { params = [], run } = result;
Expand All @@ -39,6 +44,7 @@ const useAntdTable = <TData extends Data, TParams extends Params>(

const allFormDataRef = useRef<Record<string, any>>({});
const defaultDataSourceRef = useRef([]);
const runSuccessRef = useRef(false);

const isAntdV4 = !!form?.getInternalHooks;

Expand Down Expand Up @@ -164,7 +170,15 @@ const useAntdTable = <TData extends Data, TParams extends Params>(

const submit = (e?: any) => {
e?.preventDefault?.();
_submit();
_submit(
runSuccessRef.current
? undefined
: {
pageSize: options.defaultPageSize || options.defaultParams?.[0]?.pageSize || 10,
current: 1,
...(defaultParams?.[0] || {}),
},
);
};

const onTableChange = (pagination: any, filters: any, sorter: any, extra: any) => {
Expand Down

0 comments on commit 185af79

Please sign in to comment.