chore: refresh the inert config and data files from rhiza v1.3.3 - #95
Open
tschm wants to merge 1 commit into
Open
chore: refresh the inert config and data files from rhiza v1.3.3#95tschm wants to merge 1 commit into
tschm wants to merge 1 commit into
Conversation
Nothing here executes at build, test or CI time, which is why it is separate from the rest of the template sync: - .gitignore gains entries for artifact directories the newer targets write; - cliff.toml is the git-cliff changelog config the v1.3.3 release flow reads. It is inert until that flow lands, and harmless in the meantime; - .rhiza/completions/* are the bash and zsh completion scripts, data files sourced by the user's shell, never by the build; - docs/index.md drops a stale line. Verified only in the sense that matters for this set: nothing reads any of these during a build or test run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tschm
added a commit
to tschm/pycharting
that referenced
this pull request
Aug 18, 2026
The tail of the v0.18.8 -> v1.3.3 sync: the rhiza_*.yml callers repinned from @v0.19.9 to @v1.3.3, three new workflows (fuzzing, mutation, scorecard), the pre-commit and bandit configs, the ruff rule set, TESTS.md and the lock. Everything separable has been separated and sent upstream: repo metadata (alihaskar#91), the .rhiza/tests layout (alihaskar#92), the make layer and the .rhiza/requirements removal (alihaskar#93), the packaging test and pytest.ini (alihaskar#94), and the inert config and data files (alihaskar#95). What is left needs the v1.3.3 make layer underneath it, or in ruff.toml's case needs source changes first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR refreshes “inert” (non-build/test/CI-executed) configuration and documentation artifacts synced from rhiza v1.3.3, including changelog config, shell completion scripts, and minor docs/ignore-file tweaks.
Changes:
- Add
cliff.tomlgit-cliff configuration for future changelog generation. - Update Bash/Zsh make-target completion scripts to cache parsed targets, and refresh the accompanying README.
- Minor cleanup: remove a stale blank line in
docs/index.mdand add Rust-related ignore patterns.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
docs/index.md |
Removes an extra blank line from the docs index include. |
cliff.toml |
Adds git-cliff configuration for generating CHANGELOG.md. |
.rhiza/completions/rhiza-completion.zsh |
Adds caching to reduce repeated make -qp parsing overhead. |
.rhiza/completions/rhiza-completion.bash |
Adds caching to reduce repeated make -qp parsing overhead. |
.rhiza/completions/README.md |
Updates completion installation/performance documentation. |
.gitignore |
Adds Rust artifact ignores (and touches the end-of-file region). |
Suppressed comments (2)
.rhiza/completions/README.md:265
${XDG_CACHE_HOME:-~/.cache}in this README won’t expand~in most shells (inside parameter expansion), so the documented cache path may be wrong. Use$HOME/.cacheto match the scripts’ behavior.
- The target list is cached under `${XDG_CACHE_HOME:-~/.cache}/rhiza/`, keyed per directory
.rhiza/completions/README.md:26
- The example paths use
${XDG_DATA_HOME:-~/.local/share};~won’t expand inside parameter expansion in most shells, so this snippet is misleading. Prefer$HOME/.local/share(or use the already-expanded~form without${...:-...}).
(`${XDG_DATA_HOME:-~/.local/share}/bash-completion/completions/make` for bash,
`${XDG_DATA_HOME:-~/.local/share}/zsh/site-functions/_make` for zsh) and prints
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+75
to
+90
| local -a plain_targets | ||
| if [[ -r "$cache_file.desc" ]]; then | ||
| targets=(${(f)"$(cat "$cache_file.desc")"}) | ||
| plain_targets=(${(f)"$(cat "$cache_file.plain" 2>/dev/null)"}) | ||
| else | ||
| # Cache unavailable (e.g. unwritable HOME): fall back to direct parsing | ||
| plain_targets=(${(f)"$( | ||
| make -qp 2>/dev/null | \ | ||
| awk -F':' '/^[a-zA-Z0-9_-]+:([^=]|$)/ { | ||
| split($1,A,/ /) | ||
| for(i in A) print A[i] | ||
| }' | \ | ||
| grep -v '^Makefile$' | \ | ||
| sort -u | ||
| )"}) | ||
| fi |
Comment on lines
+48
to
+56
| if [[ -r "$cache_file" ]]; then | ||
| opts=$(cat "$cache_file") | ||
| else | ||
| # Cache unavailable (e.g. unwritable HOME): fall back to direct parsing | ||
| opts=$(make -qp 2>/dev/null | \ | ||
| awk -F':' '/^[a-zA-Z0-9][^$#\/\t=]*:([^=]|$)/ {split($1,A,/ /);for(i in A)print A[i]}' | \ | ||
| grep -v '^Makefile$' | \ | ||
| sort -u) | ||
| fi |
Comment on lines
+15
to
+28
| ### Quick install (recommended) | ||
|
|
||
| From the project root: | ||
|
|
||
| ```bash | ||
| make install-completions # install for both bash and zsh | ||
| make install-completions SHELL_KIND=zsh # or just one: bash | zsh | both | ||
| ``` | ||
|
|
||
| This copies the appropriate script into your user completion directory | ||
| (`${XDG_DATA_HOME:-~/.local/share}/bash-completion/completions/make` for bash, | ||
| `${XDG_DATA_HOME:-~/.local/share}/zsh/site-functions/_make` for zsh) and prints | ||
| any follow-up step. Start a new shell afterwards. The manual methods below remain | ||
| available if you prefer to wire it up yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the files from the rhiza
v1.3.3sync that nothing executes — at build, test or CI time. That is the whole reason they are a PR of their own: they carry none of the coupling that keeps the rest of the sync together, so they can land onmasterin any order..gitignorecliff.tomlv1.3.3release flow reads — inert until that flow lands, harmless before.rhiza/completions/rhiza-completion.{bash,zsh}+README.mddocs/index.mdNo verification claimed beyond the thing that matters for this set: nothing reads any of it during a build or a test run. Independent of my other open PRs (#91, #92, #93, #94).