Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Regex Zero to Hero #62

Closed
wants to merge 2 commits into from
Closed

Add Python Regex Zero to Hero #62

wants to merge 2 commits into from

Conversation

alimirferdos
Copy link

No description provided.

Copy link
Collaborator

@Varunram Varunram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that only a single line has been added but diff shows that lines have been added and deleted. In most cases, this is due to your editor so it would be great if you could update the PR with a single line diff, thanks!

@alimirferdos
Copy link
Author

That's because I've changed the order as said in "Contribution" page to keep the list alphabetically sorted

@Varunram
Copy link
Collaborator

Varunram commented Mar 1, 2019

Yes, but that just requires one line's insertion, which was the change suggested in the initial review :)

@alimirferdos
Copy link
Author

I tried to start a new PR in order to follow the suggestion and I used the Github's editor and the result was the same! In order to keep the list sorted as suggested in this issue it works as it is here.
What should I do now? create a new PR without sorting?
The new commit of this PR was because of new PR I was trying to create while keeping the forked repository.

@Varunram
Copy link
Collaborator

Varunram commented Mar 2, 2019

Using Github's editor results in whitespace errors and indentation errors :) You would need to pull the repo locally, add your changes on top and then push to a branch of your fork, after which you can propose a PR. Please use an editor like vim which does not change indentations or line endings arbitrarily (like some other common editors may be configured to do by default). Feel free to continue this thread and ask help in case you need to, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants