support Clang 18 and 19 #2387
Merged
support Clang 18 and 19 #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
force-pushed
the
supportClang18_19
branch
from
6c2f8c0
to
fa4adc3
Compare
SimeonEhrig
force-pushed
the
supportClang18_19
branch
from
fa4adc3
to
9f6d144
Compare
With clang 18 the interface for `__popc` changed.
psychocoderHPC
force-pushed
the
supportClang18_19
branch
from
3a82473
to
941e45c
Compare
SimeonEhrig
commented
Sep 25, 2024
psychocoderHPC
force-pushed
the
supportClang18_19
branch
from
496e379
to
dcaf4d5
Compare
```
/builds/hzdr/crp/alpaka/test/unit/mem/view/src/ViewPlainPtrTest.cpp:112:1: error: passing no argument for the '...' parameter of a variadic macro is a C++20 extension [-Werror,-Wc++20-extensions]
112 | TEMPLATE_TEST_CASE("createView", "[memView]", (std::array<float, 4>), std::vector<float>)
```
psychocoderHPC
force-pushed
the
supportClang18_19
branch
from
dcaf4d5
to
41cc41a
Compare
SimeonEhrig
force-pushed
the
supportClang18_19
branch
from
c0a07d6
to
0e80212
Compare
- intermediate solution - bugs looks solvable, but there is not time yet
SimeonEhrig
force-pushed
the
supportClang18_19
branch
from
0e80212
to
4e6eb70
Compare
psychocoderHPC
approved these changes
Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully there is nothing to do because @fwyzard already fixed several Clang 18 and 19 problems during PR #2368