-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix and update SYCL targets #2390
fix and update SYCL targets #2390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to check some of the updates.
@psychocoderHPC the error in
Any ideas what may have caused it or how to reproduce it ? |
I retriggered the failing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the behaviour of HIP with @AuroraPerego, we think that all AMD GPUs starting from gfx 10.0 should support only a subgroup size of 32.
926ee82
to
f44a981
Compare
Yes I checked it against https://rocm.docs.amd.com/en/latest/reference/gpu-arch-specs.html#accelerator-and-gpu-hardware-specifications (the table has different tabs) and AMD is writing https://rocm.docs.amd.com/projects/HIP/en/latest/understand/hardware_implementation.html#rdna-architecture
|
Yes... the RDNA1, RDNA2 and RDNA3 architecture whitepapers suggest that both 32 and 64 can be used. And But HIP does not like it:
|
now all targets are defined as 0 (the one we are compiling for as 1), therefore `if defined` cannot be used. Co-authored-by: Andrea Bocci <fwyzard@gmail.com>
228aac2
to
d378ed0
Compare
Now all device targets are defined as 0, while the one(s) we are compiling for are defined as 1. Therefore
# if defined
cannot be used anymore.I've added some new targets as well.
Note that there is probably a bug with NVIDIA targets, but we are not using them for now.