Single thread acc throw for invalid workdiv fix #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than one, throw a runtime error
fwyzard
previously approved these changes
Sep 23, 2024
|
LGTM |
psychocoderHPC
requested changes
Sep 23, 2024
psychocoderHPC
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a single thread acc if the WorkDiv number of threads per block is more than one, throw a runtime error
We will now throw in create task kernel. The current approach of throwing when the task kernel is executed doesn't work.
CallbackThread::startWorkerThread, tries to handle the exception, but it needs to be dealt with the thread that creates it.