Rename namespace alpaka::concepts to alpaka::inteface #2410
Conversation
- replace the term concept in Concepts.hpp with interface e.g. for documentation, function names, template types and so one
- also rename ConceptsTest.cpp to InterfaceTest.cpp
|
@fwyzard Can you please have a look on it. I will also talk to @psychocoderHPC afterwards. |
|
I am fine with this change, this makes the way free for concepts. |
| @@ -61,13 +61,13 @@ namespace alpaka | |||
|
|
|||
| //! True if TDev is a device, i.e. if it implements the ConceptDev concept. | |||
There was a problem hiding this comment.
please check the documentation. I will merge it but we should change it in a follow up PR.
There was a problem hiding this comment.
That's something which I realized during the work at the alpaka::concepts::Tag PR. Each class which uses alpaka::interface needs to define a class, where it use it for the inheritance hierarchy. I didn't changed it in this PR, because it does not affect the functionality of the alpaka::interface functions.
I can rename all the classes in an extra PR. Also they don't follow an specific name scheme. For alpaka::concepts::Tag I use the following Interface class:
alpaka/include/alpaka/acc/Tag.hpp
Line 15 in 85c3302
Maybe I can overtake the name scheme for all other classes.
Rename the alpaka namespace
alpaka::conceptstoalpaka::interfacebecause it can be easily mixed up with C++20 concepts. Butalpaka::conceptsfunctionality does not implement C++20 with C++17. Instead it allows to implement a type hierarchy allows to check for it. That's a similar concept like Java interfaces. Therefore we name it interface now.