Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): important details on DRT #19

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Oct 10, 2024

Description

While testing the Bridge Client, I've realized that we're missing some important details on the Deposit Request Transaction (DRT) about:

  1. that the multisig N-of-N is a Schnorr aggregated sig
  2. that the OP_RETURN needs to be the first output

Type of Change

  • New Document
  • Update to Existing Document
  • Bug Fix
  • Question/clarification
  • Other (please describe):

Checklist

  • I have reviewed the existing documentation to avoid duplication.
  • The new or updated document includes clear and concise information.
  • All relevant sections (e.g., introduction, usage examples, references)
    are included.
  • The document follows the project's style guide and formatting rules.
  • I have included any necessary references or external resources.
  • Spellcheck and grammar check have been performed.
  • (For updates) I have verified that the changes reflect the current state
    of the project.

Reviewer Checklist

  • The purpose and scope of the document are clear.
  • The document is easy to understand and follow.
  • There are no typos or grammatical errors.
  • All necessary sections are included and well-structured.
  • The document is consistent with the project's style guide.
  • Any referenced links or resources are valid and appropriate.

Thank you for contributing to our documentation!

@storopoli
Copy link
Member Author

ready merge if approved

Copy link
Contributor

@john-light john-light left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-light john-light merged commit d39aa27 into main Oct 12, 2024
3 checks passed
@john-light john-light deleted the storopoli/fix-bridge-DRT branch October 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants