Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper for hiding global bar #2364

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add helper for hiding global bar #2364

wants to merge 1 commit into from

Commits on Oct 18, 2021

  1. Add helper for hiding global bar 

    Currently the global bar is initially hidden, then shown using JavaScript - this
causes a shift in the layout of the page (aka jank) and means that the global
bar is not available for users without JavaScript.

To avoid this, a change will need to be made in Static to the make the global
bar be initially shown by default. The bar can then be hidden on pages that
don't need it - and doing this using CSS will avoid jank.

This change adds a helper that checks whether a page should hide the global bar;
the view can then add a class to the body element that will hide the global bar.

These changes won't have any effect until Static has been updated.
    @injms
    injms committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    fe9ccc3 View commit details
    Browse the repository at this point in the history