Skip to content

Commit

Permalink
Remove redundant require_dependency calls
Browse files Browse the repository at this point in the history
Zeitwerk improvements have removed the necessity of these for nested models.
  • Loading branch information
pixeltrix committed Oct 19, 2024
1 parent 2fd4f04 commit fb75558
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 20 deletions.
2 changes: 0 additions & 2 deletions app/models/archived/debate_outcome.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require_dependency 'archived'

module Archived
class DebateOutcome < ActiveRecord::Base
VALID_OTHER_URLS = /\Ahttps?:\/\/(?:[a-z][\-\.a-z0-9]{0,63}\.parliament\.uk|www\.youtube\.com).*\z/
Expand Down
2 changes: 0 additions & 2 deletions app/models/archived/government_response.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require_dependency 'archived'

module Archived
class GovernmentResponse < ActiveRecord::Base
belongs_to :petition, touch: true
Expand Down
2 changes: 0 additions & 2 deletions app/models/archived/note.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require_dependency 'archived'

module Archived
class Note < ActiveRecord::Base
belongs_to :petition, touch: true
Expand Down
1 change: 0 additions & 1 deletion app/models/archived/petition.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require 'textacular/searchable'
require_dependency 'archived'

module Archived
class Petition < ActiveRecord::Base
Expand Down
2 changes: 0 additions & 2 deletions app/models/archived/petition/email.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require_dependency 'archived'

module Archived
class Petition < ActiveRecord::Base
class Email < ActiveRecord::Base
Expand Down
2 changes: 0 additions & 2 deletions app/models/archived/petition/mailshot.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require_dependency 'archived'

module Archived
class Petition < ActiveRecord::Base
class Mailshot < ActiveRecord::Base
Expand Down
2 changes: 0 additions & 2 deletions app/models/archived/rejection.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require_dependency 'archived'

module Archived
class Rejection < ActiveRecord::Base
belongs_to :petition, touch: true
Expand Down
2 changes: 0 additions & 2 deletions app/models/archived/signature.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
require 'ipaddr'

require_dependency 'archived'

module Archived
class Signature < ActiveRecord::Base
include GeoipLookup, Anonymize
Expand Down
7 changes: 2 additions & 5 deletions app/models/constituency.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
require_dependency 'constituency/api_client'
require_dependency 'constituency/api_query'

class Constituency < ActiveRecord::Base
MP_URL = "https://members.parliament.uk/member/%{mp_id}/contact"
POSTCODE = /\A([A-Z]{1,2}[0-9][0-9A-Z]?)([0-9]|[0-9][A-BD-HJLNP-UW-Z]{2})?\z/i
Expand Down Expand Up @@ -102,11 +99,11 @@ def for_parliament(parliament)
current
end
end

def between(opening_at, dissolution_at)
where(arel_table[:start_date].lteq(opening_at).and(arel_table[:end_date].gteq(dissolution_at).or(arel_table[:end_date].eq(nil))))
end

def external_ids
pluck(:external_id)
end
Expand Down

0 comments on commit fb75558

Please sign in to comment.