Display content lists on publications irrespective off h2 count

[CodeSonia]

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

[hannako]

Happy to pair on this Sonia! But thought I'd type it out so you can work through it in your own time if you prefer.

[hannako]

Once #3366 is merged and you rebase, what we need here is:

return true if contents_items.present?
return false if no_first_item?

first_item_size_requirements_met?(character_count, table_row_count)

The behaviour that we want is if there are any contents_items at all (which are basically h2's) we want show_contents_list? to return true. This is why we have the return keyword. It returns true and exits the method so the subsequent lines aren't run (we don't care about the first item if it's got an H2). It's explained well on here.

If there are no contents_items ie no H2's then we will look at the first_item, ie the first chunk of content in the body. It has to meet certain requirements, and there's logic to figure that out. But there's no point spending time running that logic if there's no first_item, so we use the Explicit return statement again... ie if there's no_first_item? we should return false and exit.

And finally, if there is a first_item, then we check if it meets various character count requirements. We don't need the return keyword here, as the last thing in a method is returned (Implicit return).

[hannako]

This file needs to have the following test cases:

1. Displays contents list if there is an H2

def body
  "<h2 id='one'>One</h2>"
end

2. Displays contents list if there is no H2 but first item is greater than 415

def body
  "<div><p>#{Faker::Lorem.characters(number: 416)}</p></div>"
end

3. Displays no contents list if there is no H2 and first item is less than 415

def body
  "<div><p>#{Faker::Lorem.characters(number: 400)}</p></div>"
end

And then the tests for the other cases (images and tables)

I think all of them are present in this file, but you just need to tweak them so that the body provides the right structure. Hope that makes sense!

[CodeSonia]

Happy to pair on this Sonia! But thought I'd type it out so you can work through it in your own time if you prefer.

Thanks Jess, this is great! I'll have a look and make a start 👀