Tests to help debug behaviour of deletion #10159
ci.yml
on: pull_request
Matrix: Test features / feature-test-matrix
Matrix: Test Ruby / minitest-matrix
CodeQL SAST scan
/
Analyze
2m 19s
Dependency Review scan
/
dependency-review-pr
6s
Dependency Review scan
/
dependency-review-push
0s
Security Analysis
/
Run Brakeman
45s
Lint SCSS
/
Run Stylelint
14s
Lint JavaScript
/
Run Standardx
12s
Prettier
/
Run Prettier
12s
Lint Ruby
/
Run RuboCop
29s
Lint ERB
/
Run ERB lint
39s
Test JavaScript
/
Run Jasmine
28s
Test features
/
Run Cucumber
0s
Test Ruby
/
Run Minitest
0s
Annotations
10 errors
Lint Ruby / Run RuboCop:
test/functional/admin/attachments_controller_test.rb#L86
Lint/RedundantCopDisableDirective: Unnecessary disabling of `Rails/SaveBang`.
|
Lint Ruby / Run RuboCop:
test/functional/admin/attachments_controller_test.rb#L90
Lint/Debugger: Remove debugger entry point `byebug`.
|
Lint Ruby / Run RuboCop:
test/functional/admin/attachments_controller_test.rb#L93
Layout/CommentIndentation: Incorrect indentation detected (column 2 instead of 4).
|
Lint Ruby / Run RuboCop:
test/functional/admin/attachments_controller_test.rb#L93
Style/CommentAnnotation: Annotation keywords like `TODO` should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords)
|
Lint Ruby / Run RuboCop:
test/integration/attachment_deletion_integration_test.rb#L109
Rails/SaveBang: Use `update!` instead of `update` if the return value is not checked. (https://rails.rubystyle.guide#save-bang)
|
Lint Ruby / Run RuboCop:
test/integration/attachment_deletion_integration_test.rb#L118
Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after `private`. (https://rubystyle.guide#empty-lines-around-access-modifier, https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
|
Lint Ruby / Run RuboCop:
test/unit/app/models/attachment_data_test.rb#L379
Layout/EmptyLines: Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines)
|
Lint Ruby / Run RuboCop:
test/unit/app/models/attachment_data_test.rb#L380
Rails/SaveBang: Use `update!` instead of `update` if the return value is not checked. (https://rails.rubystyle.guide#save-bang)
|
Lint Ruby / Run RuboCop:
test/unit/app/models/attachment_data_test.rb#L398
Rails/SaveBang: Use `update!` instead of `update` if the return value is not checked. (https://rails.rubystyle.guide#save-bang)
|
Lint Ruby / Run RuboCop:
test/unit/app/models/attachment_data_test.rb#L416
Rails/SaveBang: Use `update!` instead of `update` if the return value is not checked. (https://rails.rubystyle.guide#save-bang)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
brakeman-json
|
3.21 KB |
|