Editionable landing pages #9525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KludgeKML
force-pushed
the
editionable-landing-pages
branch
7 times, most recently
from
61d0910
to
b8f47e6
Compare
test/unit/app/presenters/publishing_api/landing_page_presenter_test.rb
Outdated
Show resolved
Hide resolved
KludgeKML
force-pushed
the
editionable-landing-pages
branch
from
b8f47e6
to
94bdaed
Compare
- LandingPage is a new document type rendered by Frontend which constructs its page using blocks specified in the details of the content item (not to be confused with the reusable content blocks project). - Here we add it as an editionable object, add a PublishingAPI presenter to allow it to be published, and update Whitehall's list of allowed rendering apps to include Frontend (this is the first, but the consolidation work means it won't be the last document type that will need this). - base_path must exist and not already be taken - body must be valid YAML (and more, root element must be blocks: - we can expand this to stricter testing, but maybe that should be by schema?) - basic tests for validation and presentation
- _form partial is required for editions - add resource route - basic controller tests
- Add additional_significant_fields partial - This handles editing the base_path the first time the document is created - allow the slug parameter in EditionsController - skip updating document slugs for landing pages. We want to be able to specify the base_path explicitly for these editions, so having them set automatically from the title is not desired. - update model test Co-authored-by: Richard Towers <richard.towers@digital.cabinet-office.gov.uk>
- Add redirect to new_document_controller to allow it to bounce landing pages to their controller.
KludgeKML
force-pushed
the
editionable-landing-pages
branch
from
94bdaed
to
d4c80fa
Compare
|
All looks good to me. I wonder if we should also set: Like we do with statistical data sets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/xZrRMK6P
Follow these steps if you are doing a Rails upgrade.