Skip to content

Commit

Permalink
revert, prevent recursion
Browse files Browse the repository at this point in the history
  • Loading branch information
wh1te909 committed Feb 9, 2024
1 parent a504a37 commit b4d25d6
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions api/tacticalrmm/agents/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,24 +126,18 @@ class Meta:
def __str__(self) -> str:
return self.hostname

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._orig_monitoring_type = self.monitoring_type
self._orig_site_id = self.site_id

def save(self, *args, **kwargs):
# prevent recursion since calling set_alert_template() also calls save()
if not hasattr(self, "_processing_set_alert_template"):
self._processing_set_alert_template = False

if self.pk and not self._processing_set_alert_template:
mon_type_changed = self.monitoring_type != self._orig_monitoring_type
site_changed = self.site_id != self._orig_site_id
orig = Agent.objects.get(pk=self.pk)
mon_type_changed = self.monitoring_type != orig.monitoring_type
site_changed = self.site_id != orig.site_id
if mon_type_changed or site_changed:
self._processing_set_alert_template = True
self.set_alert_template()
self._orig_monitoring_type = self.monitoring_type
self._orig_site_id = self.site_id
self._processing_set_alert_template = False

super().save(*args, **kwargs)
Expand Down

0 comments on commit b4d25d6

Please sign in to comment.