Skip to content
This repository has been archived by the owner on Apr 24, 2018. It is now read-only.

Added second button #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added second button #386

wants to merge 2 commits into from

Conversation

kevindekemele
Copy link

Added second button + a demo in the sample app.

Second button can be added with Builder. Has similar methods as the 'Endbutton' methods.




public void overrideButtonsClick(OnClickListener listener1,OnClickListener listener2) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to have this method, just having the two overrideButtonTwoClick and overrideButtonClick methods

@amlcurran
Copy link
Owner

Like the idea but there are a few things I'd like to see changed :) just trying to make the code as great together as we can!

  • Removing the methods which add listeners together, as I don't think they are useful enough (I like the API to be as small as possible)
  • Not having a second button by default but if someone wants one they have to add it themselves using addSecondButton() on the builder

If you'd like me to, I could create a PR with what I'm thinking?

@amlcurran
Copy link
Owner

Then we can compare the two

@kevindekemele
Copy link
Author

Sure!
I agree with your remarks.
I dont really know what you mean with inconsistent format ( Im not at all a professional software designer).

You can perform your pull request with your thoughts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants