Rescue from XML parse error when SAMLResponse contains newline chars #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters __Why__ We are receiving SAMLResponse params that contain newline characters when URI decoded. This was causing an exception in the XML parser and making for a hard to diagnose error. __How__ Rescuse the error, log the event, and clean the SAMLResponse by removing the newline characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We are receiving SAMLResponse params that contain newline characters when URI decoded. This was
causing an exception in the XML parser and making for a hard to diagnose error.
How
Rescuse the error, log the event, and clean the SAMLResponse by removing the newline characters.