Improve PHP 8.4 compatibility #11646
swissspidybuild-test-measure.yml
on: pull_request
Pre run
6s
Matrix: build-zip
Lint: CSS
16s
Lint: JS
29s
Lint: PHP
41s
Static Analysis: PHP
1m 15s
Unit test: JS
32s
Matrix: E2E test: JS
Matrix: feature-test-php
Matrix: unit-test-php
Comment on PR with links to plugin ZIPs
0s
Annotations
21 errors, 2 warnings, and 2 notices
|
Static Analysis: PHP:
includes/embeds/class-amp-youtube-embed-handler.php#L278
Call to function is_array() with array will always evaluate to true.
|
|
Static Analysis: PHP:
includes/embeds/class-amp-youtube-embed-handler.php#L479
Call to function is_array() with array{0?: string, minutes?: ''|numeric-string, 1?: ''|numeric-string, seconds?: numeric-string, 2?: numeric-string} will always evaluate to true.
|
|
Static Analysis: PHP:
includes/utils/class-amp-dom-utils.php#L376
Offset 'event' on array{0: list<string>, 1: list<non-falsy-string>, event: list<non-empty-string>, 2: list<non-empty-string>, actions: list<non-empty-string>, 3: list<non-empty-string>} in isset() always exists and is not nullable.
|
|
Static Analysis: PHP:
includes/utils/class-amp-dom-utils.php#L394
Offset 'action' on array{0: list<string>, action: list<non-empty-string>, 1: list<non-empty-string>} in isset() always exists and is not nullable.
|
|
Static Analysis: PHP
Process completed with exit code 1.
|
|
Upload plugin ZIPs to Google Cloud Storage
The v0 series of google-github-actions/setup-gcloud is no longer maintained. It will not receive updates, improvements, or security patches. Please upgrade to the latest supported versions:
https://github.com/google-github-actions/setup-gcloud
|
|
Upload plugin ZIPs to Google Cloud Storage
Process completed with exit code 1.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/src/TestCase.php#L56
Failed asserting that two strings are equal.
|
|
Unit test: PHP 8.4, WP trunk:
tests/php/validation/test-class-amp-validation-manager.php#L1745
Failed asserting that two strings are equal.
|
|
E2E test: JS (1, 2):
tests/e2e/specs/block-editor/amp-preview-button.js#L813
TimeoutError: waiting for selector `.components-button.edit-post-header__post-preview-button` failed: timeout 60000ms exceeded
at new WaitTask (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:813:28)
at DOMWorld.waitForSelectorInPage (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:656:22)
at Object.internalHandler.waitFor (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/QueryHandler.ts:78:19)
at DOMWorld.waitForSelector (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:511:25)
at Frame.waitForSelector (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/FrameManager.ts:1290:47)
at Page.waitForSelector (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/Page.ts:3222:29)
at Object.waitForSelector (/home/runner/work/amp-wp/amp-wp/tests/e2e/specs/block-editor/amp-preview-button.js:35:14)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
|
|
E2E test: JS (1, 2):
tests/e2e/specs/block-editor/featured-image-notice.js#L813
TimeoutError: waiting for XPath `//button[contains(text(), 'Set featured image')]` failed: timeout 60000ms exceeded
at new WaitTask (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:813:28)
at DOMWorld.waitForXPath (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:702:22)
at Frame.waitForXPath (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/FrameManager.ts:1320:47)
at Page.waitForXPath (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/Page.ts:3281:29)
at waitForXPath (/home/runner/work/amp-wp/amp-wp/tests/e2e/utils/click-button.js:9:28)
at Object.<anonymous> (/home/runner/work/amp-wp/amp-wp/tests/e2e/specs/block-editor/featured-image-notice.js:24:20)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
|
|
E2E test: JS (1, 2):
tests/e2e/specs/block-editor/featured-image-notice.js#L813
TimeoutError: waiting for XPath `//button[contains(text(), 'Set featured image')]` failed: timeout 60000ms exceeded
at new WaitTask (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:813:28)
at DOMWorld.waitForXPath (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/DOMWorld.ts:702:22)
at Frame.waitForXPath (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/FrameManager.ts:1320:47)
at Page.waitForXPath (/home/runner/work/amp-wp/amp-wp/node_modules/@wordpress/scripts/node_modules/puppeteer-core/src/common/Page.ts:3281:29)
at waitForXPath (/home/runner/work/amp-wp/amp-wp/tests/e2e/utils/click-button.js:9:28)
at Object.<anonymous> (/home/runner/work/amp-wp/amp-wp/tests/e2e/specs/block-editor/featured-image-notice.js:24:20)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
|
|
E2E test: JS (1, 2)
Process completed with exit code 1.
|
|
Upload plugin ZIPs to Google Cloud Storage
The following actions use a deprecated Node.js version and will be forced to run on node20: google-github-actions/setup-gcloud@20c93dacc1d70ddbce76c63ab32c35595345bdd1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Upload plugin ZIPs to Google Cloud Storage
"service_account_key" has been deprecated. Please switch to using google-github-actions/auth which supports both Workload Identity Federation and Service Account Key JSON authentication. For more details, see https://github.com/google-github-actions/setup-gcloud#authorization
|
|
E2E test: JS (2, 2)
Using Chromium from /home/runner/.cache/puppeteer/chrome/linux-126.0.6478.126/chrome-linux64/chrome
|
|
E2E test: JS (1, 2)
Using Chromium from /home/runner/.cache/puppeteer/chrome/linux-126.0.6478.126/chrome-linux64/chrome
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
amp-fix-php84-b707f6a6-dev
|
5.98 MB |
|
|
amp-fix-php84-b707f6a6-prod
|
2.49 MB |
|
|
e2e-failure-artifacts
|
191 KB |
|