Merge pull request #36 from zoltanhorvath2/fix-fatal-error-on-missing…

…-attributes-on-upload
andalisolutions · Jul 29, 2024 · 4a76777 · 4a76777
2 parents 73fe1cd + 21050f1
commit 4a76777
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 24 deletions.
diff --git a/src/Resources/Efactura.php b/src/Resources/Efactura.php
@@ -41,6 +41,10 @@ public function upload(string $xml_path, string $tax_identification_number, Uplo
         /** @var array<array-key, array{dateResponse: string, ExecutionStatus: string, index_incarcare: string}> $response */
         $response = $this->transporter->requestObject($payload);
 
+        if (! array_key_exists('@attributes', $response)) {
+            throw new RuntimeException($response['message']);
+        }
+
         return CreateUploadResponse::from($response['@attributes']);
     }
 

diff --git a/tests/Transporters/HttpTransporterObject.php b/tests/Transporters/HttpTransporterObject.php
@@ -112,30 +112,6 @@
     );
 });
 
-test('request object tax identification number not found', function () {
-    $payload = Payload::create('PlatitorTvaRest/api/v8/ws/tva', []);
-
-    $response = new Response(200, [], json_encode(
-        [
-            'cod' => 200,
-            'message' => 'SUCCESS',
-            'found' => [],
-            'notFound' => [
-                0 => 387445633,
-            ],
-        ],
-    ));
-
-    $this->client
-        ->shouldReceive('sendRequest')
-        ->once()
-        ->andReturn($response);
-
-    expect(fn () => $this->http->requestObject($payload))
-        ->toThrow(function (TaxIdentificationNumberNotFoundException $e) {
-            expect($e->getMessage())->toBe('Tax identification number not found');
-        });
-});
 
 test('request object client errors', function () {
     $payload = Payload::create('PlatitorTvaRest/api/v8/ws/tva', []);