This repository has been archived by the owner on May 28, 2019. It is now read-only.
Ui date fix date parrse and refactor #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e dateOptions if provided
…e dateOptions if provided
…e dateOptions if provided
|
|
||
|
|
||
| function parseNonDateValue(value) { | ||
| console.warn('The ng-model for ui-date have to be a Date instance. ' + |
There was a problem hiding this comment.
it's probably better to use the $log service here to write out anything
|
Thanks for this, sorry for the delay as I was away. The breaking changes worry me as we have had issues created for those in the past and the validator is now removed which I think is nice to use with angular form errors. I think I'm ok to implement if you're willing to help with issues created moving forward against this in case people are still using these features, but otherwise I could see more work coming from breaking changes. Would you be up for watching and helping? Thanks! |
|
Thank you for review. I'll take a look into details and give you answer at this weekend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Here we have following breaking changes - now all input date strings will be converted to instance of Date if possible and$viewValue will be formatted by $ .datepicker default params or they might be provided explicitly via ui-date="opts" and if we want to change format in model we could use ui-date-format as datepicker format string.