Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting the fix for #1221 #3280

Closed
wants to merge 1 commit into from

Conversation

jjkovacs
Copy link

The fix for this issue seems to have introduced various other issues. I've noticed that the column headers sometimes get out of alignment with their corresponding columns, especially when a grid contains pinned columns. This should also fix #3044.

Is the issue expressed in #1221 expected to be base behavior of a data grid? I wouldn't expect the width of the last column in a grid to be dependent on the width of the other columns by default.

If the expectation is that the row striping extends all the way across the grid, that can be done purely with css:

.gridStyle .ngCanvas {
  min-width: 100%;
}

.gridStyle .ngRow {
  min-width: 100%;
}

The last column can also be set to fill the remaining width of the row with css as well:

.gridStyle .ngRow .ngCell:last-child {
  width: auto !important;
  right: 0px;
}

.gridStyle .ngRow .ngCell:last-child .ngCellText {
  width: inherit;
}

The following plunker demonstrates this:
http://plnkr.co/edit/lqMtOz7DzPC9t9zmBRbX?p=preview

Review on Reviewable

The fix for this issue seems to have introduced various other issues.
I've noticed that the column headers sometimes get out of alignment with
their corresponding columns, especially when a grid contains pinned
columns. This should also fix angular-ui#3044.
jjkovacs referenced this pull request Apr 14, 2015
Added a padding variable as to not change the value of col.width.

(resubmitted as per request without build files
@PaulL1 PaulL1 added this to the 2.x.next milestone Apr 14, 2015
@mportuga
Copy link
Member

The issue in question appears to have been closed already. Closing this PR.

@mportuga mportuga closed this Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants