Bugfix: Add duplicate organization name check #209
Conversation
|
@mtreacy002 I solved the organization name conflict too (this time it is an organization, not a program 😂 ). I expect to face merge conflicts after #189 is merged (they tackle the same files). |
mtreacy002
added
Category: Coding
There was a problem hiding this comment.
@NenadPantelic , well done with the fix. I've tested this and it works. But can you please just make one minor change below. After that I'll write the test report and approve. Thanks
| follow_redirects=True, | ||
| content_type="application/json", | ||
| ) | ||
| self.assertEqual(HTTPStatus.CREATED, response.status_code) | ||
| self.assertEqual(messages.ORGANIZATION_SUCCESSFULLY_CREATED, json.loads(response.data)) | ||
|
|
||
| def test_api_dao_create_organization_when_name_not_unique(self): |
There was a problem hiding this comment.
@NenadPantelic perhaps rename this to "...._when_name_already_exist" to avoid ambiguity coz organization name is unique.
mtreacy002
added
Status: Changes Requested
|
@NenadPantelic , can you please give us update on this? |
|
Sorry for the delay, I'm busy with other things. I can update this in the next two or three days. Is that OK? The same goes for #189 |
|
Sure, @NenadPantelic. Thanks for responding. Will look forward to the update. Don't forget to resolve the conflict while you're at it 😉. |
|
@NenadPantelic , can we please get the updates on this? |
|
Hi @NenadPantelic are you still working on this? |
There was a problem hiding this comment.
@NenadPantelic hey any updates about this? Please resolve the merge conflicts as well. Thanks!
|
Hey, I have been busy for the past few months. I'll do my best to finish this up or to close the MR. |
Description
Added handling of the situation when the user tries to create the new organization with the name of some other persisted organization. Fixes #110.
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only