Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toast message for "no skills" filter #1207

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

abhilipsasahoo03
Copy link
Contributor

@abhilipsasahoo03 abhilipsasahoo03 commented Jul 12, 2022

Description

• Added "Skill Filter" similar to "Location Filter"

Fixes #866

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested on
Device: Redmi Note 10 Pro
OS: Android 11

Instructions to reproduce the behaviour:
• Open App -> Login using credentials -> Go to Members Page -> Open Filter option -> Enter anything into the "Skills" box that will show zero results -> Toast message pops up

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@abhilipsasahoo03
Copy link
Contributor Author

abhilipsasahoo03 commented Jul 12, 2022

@vj-codes @tinniaru3005 kindly review my PR and let me know if any change is required

Copy link
Member

@tinniaru3005 tinniaru3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abhilipsasahoo03 . Congratulations on making a PR to the project! The changes are fine. Thanks for contributing. :)

@abhilipsasahoo03
Copy link
Contributor Author

Hi @vj-codes PTAL

@abhilipsasahoo03
Copy link
Contributor Author

Hi @vj-codes please take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toast message when no user with common skills is found using filter
2 participants