fix(tui): guard Object.entries against null MCP/theme/input - #44356
Open
pantha704 wants to merge 1 commit into
Open
fix(tui): guard Object.entries against null MCP/theme/input#44356pantha704 wants to merge 1 commit into
pantha704 wants to merge 1 commit into
Conversation
TUI crash: TypeError Object.entries requires that input parameter not be null or undefined. Harden theme resolve, MCP status views, tool input formatting, and attention packs so missing objects do not take down the renderer.
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44100
Type of change
What does this PR do?
TUI dies with
TypeError: Object.entries requires that input parameter not be null or undefinedon 0.0.0-beta-17823 (same stack as #44100). Solid is iterating a value that is still null: theme colors, MCP status, toolinput, attention sounds.This PR passes
?? {}(or optional chaining) at those call sites, falls back to the built-inopencodetheme if the active one is missing, and adds a test thatresolveTheme({})does not throw.How did you verify your code works?
Added
packages/tui/test/theme.test.tscoverage for a theme object with nothemekey.Screenshots / recordings
N/A (crash guard, no UI change).
Checklist