Skip to content

Commit

Permalink
fix post_renderer argument breaking the helm deploy_command (#586)
Browse files Browse the repository at this point in the history
fix post_renderer arguments breaking the helm deploy_command

SUMMARY

The post_renderer setting is broken and resets the deploy_command instead of appending an argument. Diff should be self explanatory.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

kubernetes.core.helm
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <mgraves@redhat.com>
  • Loading branch information
pauvos authored Apr 3, 2023
1 parent deb4859 commit 8640c16
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions changelogs/fragments/586-helm-fix-post-renderer-arg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- helm - fix post_renderer argument breaking the helm deploy_command (https://github.com/ansible-collections/kubernetes.core/pull/586).
2 changes: 1 addition & 1 deletion plugins/modules/helm.py
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def deploy(
module.add_cleanup_file(path)

if post_renderer:
deploy_command = " --post-renderer=" + post_renderer
deploy_command += " --post-renderer=" + post_renderer

if skip_crds:
deploy_command += " --skip-crds"
Expand Down

0 comments on commit 8640c16

Please sign in to comment.