Skip to content

Commit

Permalink
fixup insights build (#4929)
Browse files Browse the repository at this point in the history
* fixup insights build

After #4866

looks like removing the singleton setting for react-router-dom was premature,
putting back, with an explicit version which is now required

No-Issue

* oh, the version field was just renamed, still accepts *

* update webpack check to cope with new fec format
  • Loading branch information
himdel authored Mar 19, 2024
1 parent 85eafdc commit 7197baa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
perl -ne 'print unless /^[0-9a-f]{64,64}$/d' |
grep -v '^Current branch:' |
grep -v '^Waiting for ' |
grep -v '^Root folder:' > ~/webpack-config/"$version"/"$file".json
grep -v 'Root folder:' > ~/webpack-config/"$version"/"$file".json
done
popd
Expand Down
5 changes: 5 additions & 0 deletions config/webpack.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@ module.exports = (inputConfigs) => {
exposes: {
'./RootApp': resolve(__dirname, '../src/entry-insights.tsx'),
},
shared: [
{
'react-router-dom': { singleton: true, version: '*' },
},
],
},
),
);
Expand Down

0 comments on commit 7197baa

Please sign in to comment.