Skip to content

Commit

Permalink
Bump minimal node version to 18+ (#4584)
Browse files Browse the repository at this point in the history
No-Issue
  • Loading branch information
himdel authored Nov 27, 2023
1 parent 7bd979b commit f21e8f6
Show file tree
Hide file tree
Showing 9 changed files with 30 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/automerge.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if (prTitle.includes('patternfly')) {

if (prTitle.includes('@types/node')) {
console.log('Checking for @types/node version.');
const pattern = /from 16[.]\d+[.]\d+ to 16[.]\d+[.]\d+/;
const pattern = /from (\d+)\.\d+\.\d+ to \1\.\d+\.\d+/;
if (pattern.test(prTitle)) {
console.log('Version does match the pattern ' + pattern);
} else {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 16"
- name: "Install node 18"
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'

- name: "Run automerge.js"
working-directory: ".github/workflows"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ jobs:
working-directory: 'oci_env'
run: 'oci-env compose up &'

- name: "Install node 16"
- name: "Install node 18"
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'

- name: "Cache ~/.npm & ~/.cache/Cypress"
uses: actions/cache@v3
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
uses: actions/checkout@v4

- name: "Install node 16"
- name: "Install node 18"
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'
cache: 'npm'

- name: "Checks"
Expand Down Expand Up @@ -88,10 +88,10 @@ jobs:
with:
path: 'pr'

- name: "Install node 16"
- name: "Install node 18"
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'
cache: 'npm'
cache-dependency-path: |
base/package-lock.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stable-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
RELEASE_TAG=`sed 's/^refs\/tags\///' <<< $GITHUB_REF`
echo "RELEASE_TAG=${RELEASE_TAG}" >> $GITHUB_ENV
- name: "Install node 16"
- name: "Install node 18"
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'

- name: "Cache ~/.npm"
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# WARNING
# This Dockerfile is intended for development purposes only. Do not use it for production deployments

FROM node:16-alpine
FROM node:18-alpine
WORKDIR /hub/

RUN mkdir -p /hub/app/ && \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Standalone mode only requires a running instance of the galaxy API for the UI to

1. Clone the [galaxy_ng](https://github.com/ansible/galaxy_ng) repo and follow the setup instructions
2. Start the API with `COMPOSE_PROFILE=standalone` (compose) or `COMPOSE_PROFILE=galaxy_ng/base` (oci-env)
3. Install node. Node v16+ is known to work. Older versions may work as well.
3. Install node. Node v18+ is known to work. Older versions may work as well.
4. `npm install` in the UI
5. `npm run start-standalone`

Expand Down
20 changes: 14 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@patternfly/react-code-editor": "^4.82.122",
"@patternfly/react-core": "^4.276.11",
"@patternfly/react-table": "^4.113.7",
"@types/node": "^16.18.61",
"@types/node": "^18.18.13",
"@types/react": "^17.0.2",
"@types/react-dom": "^17.0.2",
"antsibull-docs": "^1.0.0",
Expand Down Expand Up @@ -101,7 +101,7 @@
"appname": "automation-hub"
},
"engines": {
"node": ">=16",
"npm": ">=8"
"node": ">=18",
"npm": ">=9"
}
}

0 comments on commit f21e8f6

Please sign in to comment.