Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy /static/rest_framework/ to the django API #4010

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

EamonTracey
Copy link
Contributor

Issue: AAH-2148

This properly loads the CSS for DRF's API views in the browser.

Issue: AAH-2148

Signed-off-by: EamonTracey <etracey@redhat.com>
Signed-off-by: EamonTracey <etracey@redhat.com>
@himdel
Copy link
Collaborator

himdel commented Jul 20, 2023

LGTM 👍

  • insights* tests are currently broken, feel free to ignore those,
  • misc failure is unrelated, fixed in Remove alert from Task list view #4009
  • webpack-config is expected and ok, this is intentionally changing that config :)

That said, is there a corresponding oci-env PR?
Because /static/rest_framework/ only seems to be available when using the docker-compose dev env, not in oci-env.

@himdel himdel merged commit bf26dc7 into ansible:master Aug 2, 2023
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants