Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4.7] Add a 404 Dispatch page, handle some old galaxy URLs (#4090) #4121

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Aug 14, 2023

Backport #4090


  • Add a 404 Dispatch page, handle some old galaxy URLs

old galaxy UI base path is /, /{namespace}/{name}/ is a valid old galaxy URL

new galaxy UI base path is /ui/, and URLs for collections are different from URLs for legacy roles

we still want to support old URLs, so, when navigating to (new-galaxy)/foo/bar/:

  • backend will just serve the UI for unknown urls
  • UI entry-standalone will notice URLs outside the /ui/ base path, and redirect to /ui/dispatch?pathname=/foo/bar
  • /dispatch is a new route, renders a 404-like Dispatch container
  • Dispatch containers can query the APIs and show links to either the foo/bar collection or the foo/bar role, or both.

Issue: AAH-2342

  • fix Documentation link duplicate key

  • list collections and roles, show as list items

  • simplify standalone redirect

  • add/use feature flags, links to all collections/role when none found

  • dispatch empty state top bullseye

  • dispatch - use EmptyStateNoData

(cherry picked from commit e0265b4)

* Add a 404 Dispatch page, handle some old galaxy URLs

old galaxy UI base path is /, /{namespace}/{name}/ is a valid old galaxy URL

new galaxy UI base path is /ui/, and URLs for collections are different from URLs for legacy roles

we still want to support old URLs, so, when navigating to `(new-galaxy)/foo/bar/`:
* backend will just serve the UI for unknown urls
* UI entry-standalone will notice URLs outside the `/ui/` base path, and redirect to `/ui/dispatch?pathname=/foo/bar`
* /dispatch is a new route, renders a 404-like Dispatch container
* Dispatch containers can query the APIs and show links to either the foo/bar collection or the foo/bar role, or both.

Issue: AAH-2342

* fix Documentation link duplicate key

* list collections and roles, show as list items

* simplify standalone redirect

* add/use feature flags, links to all collections/role when none found

* dispatch empty state top bullseye

* dispatch - use EmptyStateNoData

(cherry picked from commit e0265b4)
@himdel himdel merged commit 2d8603e into ansible:stable-4.7 Aug 14, 2023
15 of 16 checks passed
@himdel himdel deleted the 47-4090 branch August 14, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant