Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles - update filters, add sort #4368

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Roles - update filters, add sort #4368

merged 1 commit into from
Oct 18, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 5, 2023

Issue: AAH-2791
Depends on ansible/galaxy_ng#1922 (merged)

add a HubListToolbar component to wrap CompoundFilter, AppliedFilters, Sort & top Pagination

use instead of CollectionFilter in role list & role namespace list & role namespace detail role list screens
use standard parseParamString + updateParams handling

update API wrappers & calls to use default base api methods where applicable, handle URL construction there, translate sort

add missing notfound, emptystatefilter, alerts, error handling

available filters & sorts:

  • role list
    • filters: ?keywords, ?namespace, ?tags
    • sorts (?order_by=-created): name, created, download_count
  • role namespace list
    • filters: ?keywords
    • sorts (?sort=-created): name, created
  • role namespace detail role list
    • filters: ?keywords, ?tags (+ hardcoded ?github_user)
    • sorts (?order_by=-created): name, created, download_count

20231018022609
20231018022519
20231018022545


(TODOs for later:

  • use shared listitem template in legacy, like collection list item
  • use hub-list-toolbar for collection list items too (allow switching collection sort), and in namespace list
  • grey background behind section missing in legacy)

@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 5, 2023
@himdel himdel added community comunity mode feature and removed backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 5, 2023
@himdel himdel force-pushed the sort-roles branch 6 times, most recently from 40a6f7c to 54f65f5 Compare October 17, 2023 21:28
@himdel himdel force-pushed the sort-roles branch 7 times, most recently from b796d4a to bd71d00 Compare October 18, 2023 02:25
@himdel himdel marked this pull request as ready for review October 18, 2023 03:52
@himdel himdel merged commit afebe82 into ansible:master Oct 18, 2023
17 of 18 checks passed
@himdel himdel deleted the sort-roles branch October 18, 2023 16:39
@himdel
Copy link
Collaborator Author

himdel commented Oct 24, 2023

(fixed by #4424)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community comunity mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant